Add importing strings as JsString
#4055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to import strings directly as
JsString
. This can be useful when trying to avoidTextDecoder/Encoder
, e.g. when dealing with an audio worklet.I added the
static_string
attribute item requirement because we might want to support other types in the future and we can't do type checking on the proc-macro level without knowing what the type should be. The alternative would be to do the type checking viawasm-bindgen
by using descriptors, which isn't ideal for users.Fixes #4031.